[Containment] Don't load containment actions with plasma/containment_actions KIOSK restriction
ClosedPublic

Authored by broulik on Jul 11 2018, 12:38 PM.

Details

Summary

Allows disabling all containment actions, such as context menus, middle click paste, wheel desktop switch, etc.

Test Plan

This key used to be there in 4.x but didn't really work. There also used to be a dedicated one for containment context menus but I think this distinction doesn't make a lot of sense, except maybe for disabling the context menu but still allowing virtual desktop switching on wheel?!
But then, the old docs weren't particularly clear on what "containment context menu" restricts. The comment implies it is only the containment context menu (desktop menu) while keeping applet context menus in tact? That would make it a lot more complicated to implement, ie. don't add containment actions to applet context menus etc etc.
And Harald just wants a way to show a minimalist Plasma with panels that the user cannot mess with in any way, so that patch does that.

Added the following in kdeglobals

[KDE Action Restrictions]
plasma/containment_actions=false

no longer could right click panel or desktop (system tray does its own thing and needs separate fixing).
Verified that it doesn't actually change the config file, so when the restriction is lifted, plasma loads the previously configured actions again. Also speeds up plasma startup a bit as it doesn't bother loading all the action plugins.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 11 2018, 12:38 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 11 2018, 12:38 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Jul 11 2018, 12:38 PM
broulik edited the test plan for this revision. (Show Details)

lgtm.

There's a legacy mention of this kiosk key in ContainmentInterface which should be nukable in favor of this change.

davidedmundson accepted this revision.Jul 17 2018, 1:20 PM
This revision is now accepted and ready to land.Jul 17 2018, 1:20 PM
mart accepted this revision.Jul 17 2018, 1:21 PM
This revision was automatically updated to reflect the committed changes.