The macro file name contained 'KI18N' instead of 'KI18n', like all others.
Details
compiled and did run make test
Diff Detail
- Repository
- R249 KI18n
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 1251 Build 1265: arc lint + arc unit
Similarly to D13743, i am unsure why you think i, specifically, should pay attention to this... Again, cleanups are lovely, and i support the effort, but i haven't really been involved with the Frameworks CMake system to a degree where i can tell whether a change such as this might cause issues in various places. To my understanding, the filename handling in cmake is caseless, and so it should be fine, but still... Again, looks fine, but this is fairly core stuff and that needs a bit of extra care and domain knowledge :)
Sorry, copy and paste bug
It is complicate to find the correct reviewer for a project, because by default reviews do not get any reviewer by default. .arcconfig located in a related git repo clone does not contain any hint.
Aah, yes that does happen at times :) Perhaps something to bring up on the mailing lists, something like adding the maintainers to the .arcconfigs as a hint or somesuch?