Let ki18n macro file name follow style of other find_package related files
ClosedPublic
Actions

Authored by habacker on Jun 26 2018, 6:22 PM.

Details

Reviewers

apol
ilic

Commits

R249:382cf9ca29ad: Let ki18n macro file name follow style of other find_package related files

Summary

The macro file name contained 'KI18N' instead of 'KI18n', like all others.

Test Plan

compiled and did run make test

Diff Detail

Repository

R249 KI18n

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

habacker requested review of this revision.Jun 26 2018, 6:22 PM

habacker created this revision.

Harbormaster completed remote builds in B342: Diff 36709.Jun 26 2018, 6:22 PM

Similarly to D13743, i am unsure why you think i, specifically, should pay attention to this... Again, cleanups are lovely, and i support the effort, but i haven't really been involved with the Frameworks CMake system to a degree where i can tell whether a change such as this might cause issues in various places. To my understanding, the filename handling in cmake is caseless, and so it should be fine, but still... Again, looks fine, but this is fairly core stuff and that needs a bit of extra care and domain knowledge :)

Sorry, copy and paste bug

It is complicate to find the correct reviewer for a project, because by default reviews do not get any reviewer by default. .arcconfig located in a related git repo clone does not contain any hint.

habacker edited reviewers, added: apol, ilic; removed: leinir.Jun 27 2018, 10:24 AM

Aah, yes that does happen at times :) Perhaps something to bring up on the mailing lists, something like adding the maintainers to the .arcconfigs as a hint or somesuch?

ping

apol accepted this revision.Jul 26 2018, 10:57 PM

This revision is now accepted and ready to land.Jul 26 2018, 10:57 PM

rebased

Restricted Application added a project: Frameworks. · View Herald TranscriptJul 27 2018, 8:48 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

Harbormaster completed remote builds in B1251: Diff 38567.Jul 27 2018, 8:48 AM

Closed by commit R249:382cf9ca29ad: Let ki18n macro file name follow style of other find_package related files (authored by habacker). · Explain WhyJul 27 2018, 8:50 AM

This revision was automatically updated to reflect the committed changes.

KI18n fails to install now

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (4 lines)
M			KF5I18nConfig.cmake.in (2 lines)
M			autotests/ki18n_install/CMakeLists.txt (2 lines)
V			cmake/{KF5I18NMacros.cmake.in → KF5I18nMacros.cmake.in}
V			cmake/{KF5I18nMacros.cmake.in ← KF5I18NMacros.cmake.in}

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	36709	c039aa6		Jun 26 2018, 6:22 PM	★	★
Diff 2	38567	7afa19b	- rebased	Jul 27 2018, 8:48 AM	★	★
Diff 3	38568	7afa19b	R249:382cf9ca29ada077f5e84c88f281d6a161a2c838	Jul 27 2018, 8:49 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
65c62af698e3	6a94f7bc4e1e	7afa19b90921	Ralf Habacker	Let ki18n macro file name follow style of other find_package related files (Show More…)	Jul 27 2018, 8:38 AM