There is no need for duplicate implementations. As formatValue covers
a superset, call it from formatByteSize, mapping the prefix enums.
Details
Details
- Reviewers
- None
- Group Reviewers
Frameworks - Maniphest Tasks
- T8500: Add HIG rules about use of units/symbols in (config) UI
make test
Diff Detail
Diff Detail
- Repository
- R244 KCoreAddons
- Branch
- D13584
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 842 Build 855: arc lint + arc unit
Comment Actions
I've been running with it for a while and found no issues, but only giving +1 this time because of the fallout from the other patch (which I didn't catch, so others should have a look)
Comment Actions
I don't really know this code, but one thing that could be done to ensure that the change is safe, is to increase unittest coverage (which is already not too bad, but more would be safer)