Differential D13515

Remove KNS::Engine d-pointer hack
ClosedPublic
Actions

Authored by apol on Jun 13 2018, 1:41 PM.

Details

Reviewers
leinir
mwolff
Group Reviewers
Frameworks
Commits
R304:d659619e0c96: Remove KNS::Engine d-pointer hack
Summary

Put one of the pointers in KNS::Engine in the d-pointer and normally store the
d-pointer as a class member, instead of doing it statically.

Test Plan

Tests still pass, discover still runs

Diff Detail

Repository
R304 KNewStuff
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol created this revision.Jun 13 2018, 1:41 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 13 2018, 1:41 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Jun 13 2018, 1:41 PM
leinir added a comment.Jun 13 2018, 1:45 PM

Hmmmm... this is tricky, but... yes, it seems reasonable to me that replacing one pointer with another would cause no BIC issues... and i certainly am happy to get rid of the d-pointer hack, so... if we're absolutely super-sure that this is BC, i'm all for it... would kind of like someone with better linker-fu to give word on this, but in principle, i like :)

mwolff accepted this revision.Jun 13 2018, 2:08 PM
mwolff added a subscriber: mwolff.

this is binary compatible from what I can see

This revision is now accepted and ready to land.Jun 13 2018, 2:08 PM
Closed by commit R304:d659619e0c96: Remove KNS::Engine d-pointer hack (authored by apol). · Explain WhyJun 13 2018, 4:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/engine.h (4 lines)
Msrc/core/engine.cpp (40 lines)

Diff 36098

View Options

src/core/engine.h

Loading...
View Options

src/core/engine.cpp

Loading...