Differential D13495

Fix XDGV6 popup test
ClosedPublic
Actions

Authored by davidedmundson on Jun 12 2018, 3:59 PM.

Details

Reviewers
mart
Group Reviewers
KWin
Commits
R127:64ce88d4fc3d: Fix XDGV6 popup test
Summary

We had a data funciton...then didn't use it, effectively skpping half of
the point of the test.

Test Plan

Ran the test

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Jun 12 2018, 3:59 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 12 2018, 3:59 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jun 12 2018, 3:59 PM
romangg added a subscriber: romangg.EditedJun 14 2018, 5:55 PM

What's with positioner2?

EDIT: The data function seems to be copy and paste. Other stuf fis in there which is missing in the actual test as well.

davidedmundson added a comment.Jun 14 2018, 6:07 PM

You can only set the size in the ctor, so needed a new instance.

For the rest of the tests we don't need different sizes.

mart accepted this revision.Jun 22 2018, 10:47 AM
This revision is now accepted and ready to land.Jun 22 2018, 10:47 AM
Closed by commit R127:64ce88d4fc3d: Fix XDGV6 popup test (authored by davidedmundson). · Explain WhyJun 22 2018, 10:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 36511

View Options

autotests/client/test_xdg_shell_v6.cpp

Loading...