Mouse KCM is redesigned by using Kirigami. Tested on Xorg and Wayland. Functionality is same.
New design V0.5 (Xorg)
New design V0.2 (Xorg)
New design V0.1 (Wayland)
ngraham | |
romangg | |
mart |
Mouse KCM is redesigned by using Kirigami. Tested on Xorg and Wayland. Functionality is same.
New design V0.5 (Xorg)
New design V0.2 (Xorg)
New design V0.1 (Wayland)
V0.3 will be tested on Wayland. X is tested
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Maybe we should use the same wording for the middle-click emulation feature that we did with the touchpad KCM ("Press left and right buttons for middle-click")? The reasoning being that "Emulate middle button" is a pretty technical phrase that doesn't really indicate what it does if you don't already know.
kcms/mouse/kcm/libinput/main.qml | ||
---|---|---|
29–31 | KCM.SimpleKCM |
Update V0.2
Page is converted to ScrollablePage. ExclGroupBox converted to RadioButton since the titling is issue with ExclGroupBox + ScrollablePage. Middle-click title is updated.
kcms/mouse/kcm/libinput/main.qml | ||
---|---|---|
29–31 | This is not based on KConfigModule yet so it is not okay to convert it to SimpleKCM since it'll look for "kcm" reference from the backend but will not be able to find. It is added as TODO task to the code. After this rewrite, I am planning to work on the backend so that time it may be converted to |
kcms/mouse/kcm/libinput/main_deviceless.qml | ||
---|---|---|
209 | rm line if you don't need it. |
kcms/mouse/kcm/libinput/main.qml | ||
---|---|---|
307 | This label doesn't show up. If we put it to Column, it shows up vertically centered. Please recommend a solution for this. |
V0.2
After a discussion, decided to go back to V0.2 because of some UI issues. Bug reports will be filed about the issues. For now, we'll use qqc1.
If everyone is happy and the patch is tested, I'll push the code after a last test for Wayland and Xorg.
kcms/mouse/kcm/libinput/main.qml | ||
---|---|---|
32 ↗ | (On Diff #36122) | Please re-add the minimumSizeHint line so that the window sizes itself properly when run with kcmshell5 mouse. |
kcms/mouse/kcm/libinput/main_deviceless.qml | ||
32 ↗ | (On Diff #36122) | Please re-add the minimumSizeHint line so that the window sizes itself properly when run with kcmshell5 mouse. |
kcms/mouse/kcm/libinput/main.qml | ||
---|---|---|
78 ↗ | (On Diff #36122) | This needs to stay. Try it without mouse being connected. |
for me, using qqc1 in a new kcm, is an absolute blocker, no matter what the problem is with qqc2, problems must be fixed, not worked around. ever.
So please keep following the topic and help to find the best way to fix the problems.
here a patch against this which ports it to qqc2, using the completely different radiobutton mechanics qqc2 uses, fixing separators, removing plasmacore import
kcms/mouse/kcm/libinput/main.qml | ||
---|---|---|
104–105 | this is broken, it needs Kirigami.FormData.isSection: true |
Thank you so much! I'll check it today when I back home. This will be a nice guide for me.
V0.6
Wayland version (main.qml) is tested (X was already tested). Corrections are done. Functionality is same. All the possibilities are tested. Works fine. Ready to push.