Differential D13325

Don't bother loading on non-supported platforms
ClosedPublic
Actions

Authored by broulik on Jun 4 2018, 6:47 AM.

Details

Reviewers
davidedmundson
fvogt
Group Reviewers
Plasma
Commits
R856:272f60c55557: Don't bother loading on non-supported platforms
Summary

Chrome syncs installed extensions across computers and will install it also on Windows, macOS and other unsupported platforms.
This would yield a "Make sure p-b-i package is installed" on startup the user can do nothing about.

Test Plan

5.13 branch

  • Still works fine on Linux in Chrome and Firefox
  • Added a typo to "linux" in SUPPORTED_PLATFORMS, would not try to connect to host. Didn't actually test on real Windows

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jun 4 2018, 6:47 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 4 2018, 6:47 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jun 4 2018, 6:47 AM
davidedmundson accepted this revision.Jun 4 2018, 6:48 AM
This revision is now accepted and ready to land.Jun 4 2018, 6:48 AM
Closed by commit R856:272f60c55557: Don't bother loading on non-supported platforms (authored by broulik). · Explain WhyJun 4 2018, 6:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mextension/constants.js (2 lines)
Mextension/extension.js (11 lines)

Diff 35506

View Options

extension/constants.js

Loading...
View Options

extension/extension.js

Loading...