Hide settings when run on non-supported platform
ClosedPublic

Authored by broulik on Jun 4 2018, 6:49 AM.

Details

Summary

Chrome syncs installed extensions across computers and will install it also on Windows, macOS and other unsupported platforms.
The extension doesn't work there and showing settings for features that don't exist makes no sense.
The "About" tab is still fully accessible.

Test Plan

Depends on D13325

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jun 4 2018, 6:49 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 4 2018, 6:49 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jun 4 2018, 6:49 AM
broulik updated this revision to Diff 35611.Jun 5 2018, 11:45 AM
  • Don't load settings when unsupported
  • Also don't register the save handlers
fvogt accepted this revision.Jun 5 2018, 12:11 PM
This revision is now accepted and ready to land.Jun 5 2018, 12:11 PM
This revision was automatically updated to reflect the committed changes.