Differential D13225

Move methods to private class
ClosedPublic
Actions

Authored by nicolasfella on May 31 2018, 12:00 AM.

Details

Reviewers
drosca
apol
Commits
R994:38c0b2d24bd5: Move methods to private class

Diff Detail

Repository
R994 Pulseaudio Qt Bindings
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.May 31 2018, 12:00 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 31 2018, 12:00 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.May 31 2018, 12:00 AM
mart added a subscriber: mart.Jun 7 2018, 10:18 AM

does this library have any kind of binary compatibility promise?

nicolasfella added a comment.Jun 7 2018, 10:22 AM
In D13225#275197, @mart wrote:

does this library have any kind of binary compatibility promise?

It is not yet released.

drosca accepted this revision.Jun 26 2018, 9:08 AM
This revision is now accepted and ready to land.Jun 26 2018, 9:08 AM
Closed by commit R994:38c0b2d24bd5: Move methods to private class (authored by nicolasfella). · Explain WhyJun 26 2018, 4:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/card.cpp (4 lines)
Msrc/cardport.cpp (2 lines)
Msrc/client.cpp (2 lines)
Msrc/device_p.h (5 lines)
Msrc/module.cpp (2 lines)
Msrc/port.h (3 lines)
Msrc/port_p.h (11 lines)
Msrc/profile.h (4 lines)
Msrc/profile_p.h (53 lines)
Msrc/pulseobject.h (7 lines)
Msrc/pulseobject_p.h (35 lines)
Msrc/server.h (2 lines)
Msrc/sinkinput.cpp (2 lines)
Msrc/sourceoutput.cpp (2 lines)
Msrc/stream.h (3 lines)
Msrc/stream_p.h (58 lines)
Msrc/volumeobject.h (4 lines)
Msrc/volumeobject_p.h (46 lines)

Diff 36698

View Options

src/card.cpp

Loading...
View Options

src/cardport.cpp

Loading...
View Options

src/client.cpp

Loading...
View Options

src/device_p.h

Loading...
View Options

src/module.cpp

Loading...
View Options

src/port.h

Loading...
View Options

src/port_p.h

Loading...
View Options

src/profile.h

Loading...
View Options

src/profile_p.h

Loading...
View Options

src/pulseobject.h

Loading...
View Options

src/pulseobject_p.h

Loading...
View Options

src/server.h

Loading...
View Options

src/sinkinput.cpp

Loading...
View Options

src/sourceoutput.cpp

Loading...
View Options

src/stream.h

Loading...
View Options

src/stream_p.h

Loading...
View Options

src/volumeobject.h

Loading...
View Options

src/volumeobject_p.h

Loading...