Added a few useful 'Sample commands' for the Run Command plugin
ClosedPublic

Authored by ivan on May 26 2018, 4:27 PM.

Details

Summary

Added the following example commands for the Run Command plugin:

  • Lock Screen
  • Unlock Screen
  • Close All Vaults
  • Forcefully Close All Vaults

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ivan created this revision.May 26 2018, 4:27 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptMay 26 2018, 4:27 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
ivan requested review of this revision.May 26 2018, 4:27 PM

Thanks!

plugins/runcommand/runcommand_config.cpp
47

Why not 'loginctl lock-session' like for unlocking? We try to support non-Plasma setups as good as possible.

ivan updated this revision to Diff 34935.May 26 2018, 6:31 PM

Using loginctl for session locking as well

ivan marked an inline comment as done.May 26 2018, 6:31 PM

Thanks for the suggestion!

ngraham resigned from this revision.May 26 2018, 8:33 PM

I don't use KDE Connect since I don't have an Android phone, but this definitely looks useful!

I don't use KDE Connect since I don't have an Android phone, but this definitely looks useful!

Shame on you :P If KDE Connect is not enough reason to use an Android phone I don't know what is :D

It's partly laziness (I got a free iPhone 5 from a friend) and partly privacy: among the big commercial phone companies, I believe that Apple cares more about my privacy than Google does. Google's entire business model revolves around harvesting people's personal information, but Apple makes all its money from selling hardware. Apple has no financial incentive to spy on me. They've even stood up to governments before when asked to turn over personal information.

ivan added a comment.May 26 2018, 8:56 PM

So... accepted? :)

Since I've never even used the app once, I don't feel like it would be responsible for me to formally review the change. Still, it looks like an improvement just from glancing at the code!

ivan added a comment.May 26 2018, 8:58 PM

Was more aimed at @nicolasfella :)

nicolasfella accepted this revision.May 26 2018, 9:03 PM
This revision is now accepted and ready to land.May 26 2018, 9:03 PM
This revision was automatically updated to reflect the committed changes.