In normal usage Konsole offsets the position of the mouse
by half a char so that the user can extend the selection to
the last column. When using programs interested with
mouse (vim, mc, aptitude, etc...) Konsole shouldn't apply
the offset since mouse events should always apply to the
character cell under the pointer. This patch sets the 'edge'
flag of getCharacterPosition to !_usesMouseTracking.
Details
Details
Diff Detail
Diff Detail
- Repository
- R319 Konsole
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I think we need to fix _mouseMarks at some point
FIXME: the actual value of _mouseMarks is the opposite of its semantic.
When using programs not interested with mouse(shell, less), it is true.
// When using programs interested with mouse(vim,mc), it is false.
Comment Actions
Can you try to use arcanist for patches? Once you have it setup, it should help. Currently your patches don't have the author set. I can work around it until you get is working.
https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches
Comment Actions
Do you have time to rebase and change these to !_usesMouseTracking? If not, I can do it.
Comment Actions
I'm afraid I've opened a new revision. Can you close D13179 ?
Also is this one ok?
Sorry for the noise, these tools are new for me.
Comment Actions
Ok, I've updated this revision with what I think is the correct patch to be applied on the current code and I've closed the revision I've opened by mistake yesterday. If there is something left to fix please proceed, I'm not touching anything. In case you need to check out the full code base, this patch is also published here: https://github.com/mbeniamino/konsole (commit 14f0bcc3788fe4ad7809caad971bbbec9d9ba320).