Replace setUserTitle() with setSessionAttribute()

Authored by ahmadsamir on May 28 2018, 5:42 PM.

Description

Replace setUserTitle() with setSessionAttribute()

Summary:
Session:setUserTitle() changes various attributes of the current
session/tab, not just the title; change the name from "Title" to
"sessionAttribute" as that's more representative of what the function
does. Propagate the change where appropriate throughout the code.

Remove Vt102Emulation::requestWindowAttribute(), as it's not used
anywhere.

Update a couple of links to Qt and XTerm documentation, respectively.

Test Plan:
Every thing should work as before, for example changing the window title:

  • "Show window title on the titlebar" must be enabled
  • unset PROMPT_COMMAND (in case it already sets the window title)
  • Change the window title:

printf "\033]2;%s\007" "testing"

Reviewers: Konsole, hindenburg

Reviewed By: Konsole, hindenburg

Subscribers: hindenburg, konsole-devel, Konsole

Tags: Konsole

Differential Revision: https://phabricator.kde.org/D13147

Details

Committed
hindenburgMay 28 2018, 6:07 PM
Reviewer
Konsole
Differential Revision
D13147: Replace setUserTitle() with setSessionAttribute()
Parents
R319:a2ad2d70d45d: Invert the logic for Mouse Tracking events
Branches
Unknown
Tags
Unknown