Differential D13005

cmake: add warning when baloo will be disabled
ClosedPublic
Actions

Authored by elvisangelaccio on May 20 2018, 4:54 PM.

Details

Reviewers
rkflx
ngraham
Commits
R318:7a5dbbc6c584: cmake: add warning when baloo will be disabled
Summary

KFileMetaDataWidget is useless without nepomuk (which no one ships
anymore). Let's add at least a warning until we will get rid of
kdelibs4support (see T8720).

Test Plan

Uninstall baloo-widgets, build dolphin and check the cmake output.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Dolphin. · View Herald TranscriptMay 20 2018, 4:54 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
elvisangelaccio requested review of this revision.May 20 2018, 4:54 PM
ngraham accepted this revision.May 20 2018, 5:25 PM

Better than nothing until we can drop support, as you said.

This revision is now accepted and ready to land.May 20 2018, 5:25 PM
rkflx accepted this revision.May 21 2018, 6:08 AM

After fixing my build environment, the test plan actually works – who knew…

Closed by commit R318:7a5dbbc6c584: cmake: add warning when baloo will be disabled (authored by elvisangelaccio). · Explain WhyMay 21 2018, 8:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (1 line)

Diff 34610

View Options

CMakeLists.txt

Loading...