add test which checks the property types
ClosedPublic

Authored by astippich on May 17 2018, 7:51 PM.

Details

Summary

Check the type of the properties defined in kfilemetadata vs. the actual returned types obtained from QVariant.
Testing only one file is sufficient as this is shared code. Expected failures are declared as such.

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.May 17 2018, 7:51 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptMay 17 2018, 7:51 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.May 17 2018, 7:51 PM

Sorry for the delay on my side.
Why are you adding this test ?

I would like to work on D11365 again where it was suggested to add the test first. As you can see from the tests, the types defined for each property in KFileMetaData do not match the output for the taglibextractor. The types are actually different if you query via Baloo or if you use KFileMetaData directly.

astippich updated this revision to Diff 48691.Jan 4 2019, 7:14 PM
  • rebase
  • cleanup

ping! I would like to land this as a preparation for T8196

astippich updated this revision to Diff 51550.Feb 12 2019, 9:09 PM
  • fix space

If no-one objects, I will land this next week

This revision was not accepted when it landed; it landed in state Needs Review.Feb 23 2019, 3:30 PM
This revision was automatically updated to reflect the committed changes.