Differential D12942

Simplify code in Konsole
AbandonedPublic
Actions

Authored by tcanabrava on May 17 2018, 9:20 AM.

Details

Reviewers

None

Group Reviewers

Konsole

Summary

This review is a collection of small improvements on Konsole's code

Removed some calls that the only thing it did was to forward with the same arguments the call to another object
Do not store temporary just to do a call in the next line
Remove duplicated code
Remove this-> used unecessarely
Use the newSession from the ViewManager
Remove StackedView, use TabbedBar with Hidden Tab

Test Plan

manually running konsole and testing

Diff Detail

Repository

R319 Konsole

Branch

simplifyCode

Lint

No Linters Available

Unit

No Unit Test Coverage

tcanabrava created this revision.May 17 2018, 9:20 AM

Restricted Application added a project: Konsole. · View Herald TranscriptMay 17 2018, 9:20 AM

Restricted Application added a subscriber: konsole-devel. · View Herald Transcript

tcanabrava requested review of this revision.May 17 2018, 9:20 AM

tcanabrava retitled this revision from Remove unecessary forward-calls to Simplify code in Konsole.May 17 2018, 9:24 AM

tcanabrava edited the summary of this revision. (Show Details)

tcanabrava added a reviewer: Konsole.

Thanks for working on this. I've wanted to remove the stackedview for some time. Can you separate that part into its own ticket?

There is one visible tab in KonsolePart now, it shouldn't be there.

Test (without make install):

export LD_LIBRARY_PATH=$(realpath ./src)
export QT_PLUGIN_PATH=$(realpath ./src)
./src/tests/demo_konsolepart/src/demo_konsolepart

In D12942#264411, @mglb wrote:
There is one visible tab in KonsolePart now, it shouldn't be there.

Test (without make install):
export LD_LIBRARY_PATH=$(realpath ./src)
export QT_PLUGIN_PATH=$(realpath ./src)
./src/tests/demo_konsolepart/src/demo_konsolepart

good to know, I'll find what's going on and remove the extra tab.

In D12942#264098, @hindenburg wrote:

Thanks for working on this. I've wanted to remove the stackedview for some time. Can you separate that part into its own ticket?

Sure, I'll do that. I'll close this and reopen just the removal of the StackedView in other ticket.

Split in multiple tickets.

Revision Contents
Changeset List

			Path	Packages
M			src/Application.cpp (6 lines)
M			src/MainWindow.h (11 lines)
M			src/MainWindow.cpp (72 lines)
M			src/ViewContainer.h (23 lines)
M			src/ViewContainer.cpp (51 lines)
M			src/ViewManager.h (13 lines)
M			src/ViewManager.cpp (102 lines)

Commit	Tree	Parents	Author	Summary	Date
4697910a450e	06fecf6b4a83	09b12ca3aacd	Tomaz Canabrava	Remove StackedView, use TabbedBar with Hidden Tab	May 17 2018, 9:17 AM
09b12ca3aacd	9263ec356f25	9defb9f0a856	Tomaz Canabrava	Use the newSession from the ViewManager (Show More…)	May 16 2018, 2:55 PM
9defb9f0a856	ff89591c8f15	d75292de5a2f	Tomaz Canabrava	Remove this-> used unecessarely	May 16 2018, 2:48 PM
d75292de5a2f	b6c10e1933ed	86956990d0e2	Tomaz Canabrava	Don't copy the tabs, create a new session	May 16 2018, 2:41 PM
86956990d0e2	ddc0662e88f3	b9753f6c3e8b	Tomaz Canabrava	Remove triplicated code	May 16 2018, 2:36 PM
b9753f6c3e8b	aa7b6dd18b89	c7f38672a0c0	Tomaz Canabrava	Do not add a new tav in every view (Show More…)	May 16 2018, 2:00 PM
c7f38672a0c0	45e16fa396a4	afd91c36a26c	Tomaz Canabrava	Do not store temporary just to do a call in the next line	May 16 2018, 1:59 PM
afd91c36a26c	419b9a8befbb	f65e5a5797bb	Tomaz Canabrava	Remove unecessary forward-calls (Show More…)	May 16 2018, 1:41 PM