Fix cursor advancement in last column

Authored by mglb on May 14 2018, 1:25 PM.

Description

Fix cursor advancement in last column

Summary:
Until now, the cursor was moved from last column to the next column
outside the screen. Since screen array is linear, it partially worked
like it was on the beginning of a next line (as long as it was not the
last line).

Test Plan:

  • Run cat > /dev/null (shells do their own line wrapping, so will not work)
  • Move cursor to terminal's last visible line using enter
  • Move cursor to terminal's last visible column by typing something
  • Type one more character

Expected result: new line should appear with the cursor on the beginning
Actual result: cursor disappears, no new line

  • Turn on blinking cursor
  • Run cat > /dev/null
  • Move cursor to terminal's last visible column by typing something
  • Type one more character

Expected result: the cursor should move to new line's first column
and blink
Actual result: the cursor "moves" but does not blink

Reviewers: Konsole, hindenburg

Reviewed By: Konsole, hindenburg

Subscribers: konsole-devel, hindenburg, Konsole

Tags: Konsole

Differential Revision: https://phabricator.kde.org/D12554

Details

Committed
hindenburgMay 14 2018, 2:46 PM
Reviewer
Konsole
Differential Revision
D12554: Fix cursor advancement in last column
Parents
R319:242a9fb19d8d: update docs for file used with --tabs-from-file
Branches
Unknown
Tags
Unknown