Add mute microphone global shortcut
ClosedPublic

Authored by drosca on Apr 2 2016, 11:18 AM.

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca updated this revision to Diff 3074.Apr 2 2016, 11:18 AM
drosca retitled this revision from to Add mute microphone global shortcut.
drosca updated this object.
drosca edited the test plan for this revision. (Show Details)
drosca added a reviewer: Plasma.
drosca added a project: Plasma.
drosca added a subscriber: plasma-devel.
drosca updated this revision to Diff 3079.Apr 2 2016, 3:50 PM

Also add mic volume up/down

broulik added a subscriber: broulik.Apr 2 2016, 4:53 PM
broulik added inline comments.
applet/contents/ui/main.qml
91 ↗(On Diff #3079)

I'd prefer if the parameter was named args and you pass it a JS object, like

increaseMicrophoneVolume({showOsd: true})

Avoids boolean trap. Again, same in the old code and to be fixed separately.

src/qml/volumeosd.cpp
42 ↗(On Diff #3079)

Doesn't that block introspecting?

I know it's in the old code but should be fixed later I guess

drosca added inline comments.Apr 7 2016, 6:56 AM
applet/contents/ui/main.qml
91 ↗(On Diff #3079)

Yeah, that looks better. Will change it in next commit.

src/qml/volumeosd.cpp
42 ↗(On Diff #3079)

It's generated from XML, so it does not introspect.
But indeed should be constructed just once.

sebas accepted this revision.May 5 2016, 1:05 AM
sebas added a reviewer: sebas.
sebas added a subscriber: sebas.

Nice, my laptop even has the mic mute key.

This revision is now accepted and ready to land.May 5 2016, 1:05 AM
This revision was automatically updated to reflect the committed changes.