BUG: 353102
Details
Details
- Reviewers
sebas - Group Reviewers
Plasma - Commits
- R115:9833c2c05507: Add mute microphone global shortcut
R994:9833c2c05507: Add mute microphone global shortcut
Diff Detail
Diff Detail
- Repository
- R115 Plasma Audio Volume Applet
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
applet/contents/ui/main.qml | ||
---|---|---|
91 ↗ | (On Diff #3079) | I'd prefer if the parameter was named args and you pass it a JS object, like increaseMicrophoneVolume({showOsd: true}) Avoids boolean trap. Again, same in the old code and to be fixed separately. |
src/qml/volumeosd.cpp | ||
42 ↗ | (On Diff #3079) | Doesn't that block introspecting? I know it's in the old code but should be fixed later I guess |