Differential D1291

Add microphone volume OSD
ClosedPublic
Actions

Authored by drosca on Apr 2 2016, 11:04 AM.

Details

Reviewers
sebas
Group Reviewers
Plasma: Design
Plasma
Commits
R871:f950f7843e60: Add microphone volume OSD
R120:f950f7843e60: Add microphone volume OSD

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca updated this revision to Diff 3072.Apr 2 2016, 11:04 AM
drosca retitled this revision from to Add microphone volume OSD.
drosca updated this object.
drosca edited the test plan for this revision. (Show Details)
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptApr 2 2016, 11:04 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
drosca added a comment.Apr 2 2016, 11:06 AM

Maybe would be better to have microphone-volume-low/medium-high icons as for audio volume.

colomar added a subscriber: colomar.Apr 2 2016, 2:41 PM

I've asked Andreas to create the needed icons, please wait for them to arrive.

drosca updated this revision to Diff 3373.Apr 16 2016, 6:08 AM

Update to use new icons

sebas accepted this revision.May 5 2016, 1:02 AM
sebas added a reviewer: sebas.
sebas added a subscriber: sebas.

Cool! :)

This revision is now accepted and ready to land.May 5 2016, 1:02 AM
drosca edited edge metadata.May 6 2016, 7:43 AM
drosca added a subscriber: andreaska.
drosca added a comment.May 6 2016, 7:46 AM

I've now realized that Gnome uses different icon names for microphone volume: https://github.com/GNOME/adwaita-icon-theme/blob/master/src/fullcolor/microphones.svg

microphone-sensitivity-muted
microphone-sensitivity-low
microphone-sensitivity-medium
microphone-sensitivity-high

I think it would be better if we follow the naming, @andreaska can you please rename it in breeze? Thanks

Closed by commit R120:f950f7843e60: Add microphone volume OSD (authored by drosca). · Explain WhyMay 18 2016, 8:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell/osd.h (1 line)
Mshell/osd.cpp (18 lines)

Diff 3867

View Options

shell/osd.h

Loading...
View Options

shell/osd.cpp

Loading...