Differential D12919

[Plotter] Don't render if m_node is null
ClosedPublic
Actions

Authored by broulik on May 16 2018, 7:32 AM.

Details

Reviewers
bshah
davidedmundson
Group Reviewers
Plasma
Commits
R296:9d7c4927e506: [Plotter] Don't render if m_node is null
Summary

m_node is deleted when window changes, we would access it inconditionally in render

BUG: 394283

Test Plan

Compiles.

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.May 16 2018, 7:32 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 16 2018, 7:32 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.May 16 2018, 7:32 AM
bshah accepted this revision.May 16 2018, 7:33 AM
bshah added a subscriber: bshah.

Sounds good to me.

This revision is now accepted and ready to land.May 16 2018, 7:33 AM
davidedmundson added a subscriber: davidedmundson.May 16 2018, 8:52 AM

Have you seen 2617a2ab9d472a78559f11ee8d430d951e3335f2

The point we set m_node to null we disconnect the connection that calls render.

Do you know if that bug reporter had 2617a2ab9d472a78559f11ee8d430d951e3335f2 applied?

but given we check m_window, checking m_node does makes sense for the same reasons

broulik added a comment.May 16 2018, 11:36 AM

Do you know if that bug reporter had 2617a2ab9d472a78559f11ee8d430d951e3335f2 applied?

Given it said Frameworks 5.46 I would assume so

davidedmundson accepted this revision.May 17 2018, 10:28 AM

I think it makes sense in the following situation:

a remove window event is queued
a render event is queued

we'll have set node to null, and called disconnect, but we'll still be processing pending events.

Ship it

Closed by commit R296:9d7c4927e506: [Plotter] Don't render if m_node is null (authored by broulik). · Explain WhyMay 17 2018, 10:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 34356

View Options

src/qmlcontrols/kquickcontrolsaddons/plotter.cpp

Loading...