Differential D12881

Migrate to Oreo and drop support for APIs < 16
ClosedPublic
Actions

Authored by albertvaka on May 14 2018, 11:16 PM.

Details

Reviewers
None
Group Reviewers
KDE Connect
Commits
R225:ebf63dd29417: Migrate to Oreo and drop support for APIs < 16
Summary
  • Add a foreground notification to the background service
  • Add channel to notifications.
  • Remove unneeded permission
  • Remove legacy ciphers now that we don't support API<16

Android 2.3 support needs to be dropped next September 2018 anyway.

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
albertvaka created this revision.May 14 2018, 11:16 PM
Restricted Application added a subscriber: kdeconnect. · View Herald TranscriptMay 14 2018, 11:16 PM
albertvaka requested review of this revision.May 14 2018, 11:16 PM
albertvaka added a comment.May 14 2018, 11:20 PM

This has everything from the "oreo" branch, rebased onto master, plus:

  • Updated to the latest set of build tools and sdk version.
  • Adds three different notification channels instead of only one.
  • Removes the use of specific SSL ciphers.
  • Removes a permission that the Android linter said was not needed.
albertvaka added a comment.May 14 2018, 11:21 PM

According to Google Play, there are 290 users on Android 4.0 and 120 on Android 2.3.

apol edited the summary of this revision. (Show Details)May 14 2018, 11:53 PM
nicolasfella added a comment.May 15 2018, 12:04 AM

Any reason not to wait until September?

albertvaka added a comment.May 15 2018, 7:57 AM
In D12881#262558, @nicolasfella wrote:

Any reason not to wait until September?

Nope, I just wanted to get the branch updated and also get some feedback on the code changes. I can just leave this changes in the oreo branch again until later this year.

albertvaka added a comment.May 16 2018, 3:28 PM

According to Aleix, it seems the app gets killed in Android Oreo without this, so maybe it should be released earlier than that. I propose making a Beta release with this branch.

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2018, 9:36 PM
Closed by commit R225:ebf63dd29417: Migrate to Oreo and drop support for APIs < 16 (authored by albertvaka). · Explain Why
This revision was automatically updated to reflect the committed changes.
albertvaka added a comment.May 21 2018, 3:58 PM

Merged in branch "oreo2" and released on the Play Store Beta channel.

Revision Contents
Changeset List

Diff 34552

View Options

res/values/strings.xml

Loading...
View Options

src/org/kde/kdeconnect/Helpers/NotificationHelper.java

Loading...
View Options

src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisMediaSession.java

Loading...