maximilianocuria (Maximiliano Curia)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Dec 6 2016, 7:26 PM (136 w, 1 d)
Availability
Available

Recent Activity

May 22 2018

maximilianocuria added inline comments to D11235: Request change of ptrace scope from KCrash.
May 22 2018, 11:13 AM · Plasma
maximilianocuria added a comment to D13018: Fix unit test for kfileplacesmodeltest.

Hmm, still seems to fail here:

$ ctest -R kfileplacesmodeltest
Test project /home/elvis/dev/kde/kio/local-build
    Start 50: kiofilewidgets-kfileplacesmodeltest
1/1 Test #50: kiofilewidgets-kfileplacesmodeltest ...***Failed    0.60 sec
********* Start testing of KFilePlacesModelTest *********
Config: Using QtTest library 5.11.0, Qt 5.11.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 8.1.0)
QDEBUG : KFilePlacesModelTest::initTestCase() void Solid::Backends::Fake::FakeManager::parseMachineFile() Parsing fake computer XML:  "/home/elvis/dev/kde/kio/autotests/fakecomputer.xml" 

PASS   : KFilePlacesModelTest::initTestCase()
FAIL!  : KFilePlacesModelTest::testInitialState() Compared values are not the same
   Actual   (m_places->rowCount()): 6
   Expected (4)                   : 4
   Loc: [../autotests/kfileplacesmodeltest.cpp(200)]
QDEBUG : KFilePlacesModelTest::testInitialList() Expected: ("/home/elvis", "/", "trash:/", "remote:/", "/media/nfs", "/foreign", "/media/floppy0", "/media/XO-Y4", "/media/cdrom")
QDEBUG : KFilePlacesModelTest::testInitialList() Got: ("/home/elvis", "/home/elvis/Desktop", "/home/elvis/Downloads", "/", "trash:/", "remote:/")
FAIL!  : KFilePlacesModelTest::testInitialList() Compared lists have different sizes.
   Actual   (placesUrls()) size: 6
   Expected (urls) size: 9
   Loc: [../autotests/kfileplacesmodeltest.cpp(236)]
May 22 2018, 8:52 AM · Frameworks

May 17 2018

maximilianocuria added a watcher for Konsole: maximilianocuria.
May 17 2018, 7:49 AM

May 16 2018

maximilianocuria committed R237:c1fa17e99ad9: KConfigCompiler_Test: Update test_signal.h.ref to follow the generated file (authored by maximilianocuria).
KConfigCompiler_Test: Update test_signal.h.ref to follow the generated file
May 16 2018, 6:39 AM
maximilianocuria closed D12892: KConfigCompiler_Test: Update test_signal.h.ref to follow the generated file.
May 16 2018, 6:39 AM · Frameworks

May 15 2018

maximilianocuria requested review of D12898: Add missing header.
May 15 2018, 3:56 PM · Frameworks
maximilianocuria requested review of D12892: KConfigCompiler_Test: Update test_signal.h.ref to follow the generated file.
May 15 2018, 9:38 AM · Frameworks

May 14 2018

maximilianocuria requested review of D12877: GIT_SILENT fix minor typo in the license name.
May 14 2018, 3:18 PM · Frameworks
maximilianocuria added reviewers for D12872: ScalableTest, add "scalable" plasma-browser-integration: Frameworks, dfaure, andreaska, andreask.
May 14 2018, 1:18 PM · Frameworks
maximilianocuria updated the test plan for D12872: ScalableTest, add "scalable" plasma-browser-integration.
May 14 2018, 1:17 PM · Frameworks
maximilianocuria requested review of D12872: ScalableTest, add "scalable" plasma-browser-integration.
May 14 2018, 11:50 AM · Frameworks
maximilianocuria added a comment to D12867: Fix minor documentation typos.

Sadly the commit went without the GIT_SILENT, sorry about that. I did:
arc amend
git commit -amend # to add the GIT_SILENT
arc land
I guess that the arc land called another arc amend.

May 14 2018, 9:37 AM · Build System, Frameworks
maximilianocuria committed R240:ac730a209953: Fix minor documentation typos (authored by maximilianocuria).
Fix minor documentation typos
May 14 2018, 9:36 AM
maximilianocuria closed D12867: Fix minor documentation typos.
May 14 2018, 9:34 AM · Build System, Frameworks
maximilianocuria updated the summary of D12867: Fix minor documentation typos.
May 14 2018, 9:22 AM · Build System, Frameworks
maximilianocuria added a comment to D12867: Fix minor documentation typos.

Please let me know if it's okay to land this kind of changes directly.

May 14 2018, 9:22 AM · Build System, Frameworks
maximilianocuria requested review of D12867: Fix minor documentation typos.
May 14 2018, 9:21 AM · Build System, Frameworks

May 11 2018

maximilianocuria committed R126:80efc14fd844: Fix filetypestest (authored by maximilianocuria).
Fix filetypestest
May 11 2018, 9:37 AM
maximilianocuria closed D12781: Fix filetypestest.
May 11 2018, 9:37 AM · Plasma

May 9 2018

maximilianocuria committed R120:4895a975c218: Avoid including the generated config-X11 private header (authored by maximilianocuria).
Avoid including the generated config-X11 private header
May 9 2018, 12:01 PM
maximilianocuria closed D12780: Avoid including the generated config-X11 private header.
May 9 2018, 12:01 PM · Plasma
maximilianocuria requested review of D12781: Fix filetypestest.
May 9 2018, 11:54 AM · Plasma
maximilianocuria requested review of D12780: Avoid including the generated config-X11 private header.
May 9 2018, 11:46 AM · Plasma

May 8 2018

maximilianocuria added a comment to D12702: Avoid giving an stderr to kwallet.

Btw, Debian users confirmed that this fixes the issue: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=897687

May 8 2018, 7:28 AM · Plasma
maximilianocuria added a comment to D12702: Avoid giving an stderr to kwallet.

I'm not sure, but I think that pam could be called from a process that has the stdin/stdout/stderr redirected to pipes, so disconnecting those for a long lived process would avoid a possible broken pipe. Now, if that's so, why it's not clossing stdin and stdout, I don't know.

May 8 2018, 7:21 AM · Plasma

May 5 2018

maximilianocuria committed R107:14c5f2032362: Avoid giving an stderr to kwallet (authored by maximilianocuria).
Avoid giving an stderr to kwallet
May 5 2018, 10:07 AM
maximilianocuria committed R107:af15f067bddc: Merge branch 'Plasma/5.12' into master (authored by maximilianocuria).
Merge branch 'Plasma/5.12' into master
May 5 2018, 10:07 AM
maximilianocuria committed R107:8da1a47035fc: Avoid giving an stderr to kwallet (authored by maximilianocuria).
Avoid giving an stderr to kwallet
May 5 2018, 10:07 AM
maximilianocuria closed D12702: Avoid giving an stderr to kwallet.
May 5 2018, 10:07 AM · Plasma
maximilianocuria updated the diff for D12702: Avoid giving an stderr to kwallet.

Update comments as suggested.

May 5 2018, 9:57 AM · Plasma
maximilianocuria added a comment to D12702: Avoid giving an stderr to kwallet.

I can reproduce the issue in openbox and cinnamon. I think this is related to qt5ct which always tries to print things to stderr. I guess having the debug messages enabled would also trigger the issue.

May 5 2018, 9:32 AM · Plasma

May 4 2018

maximilianocuria updated the diff for D12702: Avoid giving an stderr to kwallet.

A somewhat simpler version, just delay the close(2) call. Based on @davidedmundson
suggestion.

May 4 2018, 9:41 PM · Plasma
maximilianocuria requested review of D12702: Avoid giving an stderr to kwallet.
May 4 2018, 8:41 PM · Plasma

May 2 2018

maximilianocuria committed R161:0ed1320810cb: Migrate to ecm_qt_declare_logging_category (authored by maximilianocuria).
Migrate to ecm_qt_declare_logging_category
May 2 2018, 11:56 AM
maximilianocuria closed D12658: Migrate to ecm_qt_declare_logging_category.
May 2 2018, 11:56 AM · Plasma
maximilianocuria requested review of D12658: Migrate to ecm_qt_declare_logging_category.
May 2 2018, 10:56 AM · Plasma
maximilianocuria committed R161:25491ccb061d: Use category logging (authored by maximilianocuria).
Use category logging
May 2 2018, 9:56 AM
maximilianocuria closed D12656: Use category logging.
May 2 2018, 9:56 AM · Plasma
maximilianocuria retitled D12656: Use category logging from WIP: Use category logging to Use category logging.
May 2 2018, 9:56 AM · Plasma
maximilianocuria requested review of D12656: Use category logging.
May 2 2018, 9:10 AM · Plasma

Apr 25 2018

maximilianocuria resigned from D12513: CVE-2018-10361: privilege escalation.
Apr 25 2018, 12:07 PM · Frameworks, Kate
maximilianocuria added a comment to D12513: CVE-2018-10361: privilege escalation.

Mmh, the accept revision doesn't work as a +1, does it?
I was intending to say +1/thumbs up, but I would still prefer somebody else to review this. After all, I sent forwarded the original patch, clearly I want this to land, but it's up the frameworks/ktexteditor developers/maintainers to decide.

Apr 25 2018, 12:00 PM · Frameworks, Kate
maximilianocuria accepted D12513: CVE-2018-10361: privilege escalation.
Apr 25 2018, 11:57 AM · Frameworks, Kate
maximilianocuria added a comment to D12513: CVE-2018-10361: privilege escalation.

There's a typo in the title, it should be "privilege escalation".

Apr 25 2018, 11:42 AM · Frameworks, Kate
maximilianocuria retitled D12513: CVE-2018-10361: privilege escalation from CVE-2018-10361: privelege escalation to CVE-2018-10361: privilege escalation.
Apr 25 2018, 11:42 AM · Frameworks, Kate
maximilianocuria added a comment to D12513: CVE-2018-10361: privilege escalation.

Why dropping syncToDisk? Why is that related to the current issue?

Apr 25 2018, 10:22 AM · Frameworks, Kate
maximilianocuria updated the summary of D12513: CVE-2018-10361: privilege escalation.
Apr 25 2018, 10:08 AM · Frameworks, Kate
maximilianocuria requested review of D12513: CVE-2018-10361: privilege escalation.
Apr 25 2018, 10:06 AM · Frameworks, Kate

Apr 19 2018

maximilianocuria added a comment to D12215: Add a "Reload" menu item to KDirOperator's context menu.

You are planning a bit ahead, aren't you. :)

Apr 19 2018, 7:43 AM · Frameworks

Apr 23 2017

maximilianocuria committed R263:0570614d5671: Reproducible builds: drop version from XMLGUI_COMPILING_OS (authored by maximilianocuria).
Reproducible builds: drop version from XMLGUI_COMPILING_OS
Apr 23 2017, 7:50 AM

Jan 29 2017

maximilianocuria committed R319:bb5ef879586c: Add the _lineSpacing value set by the user. (authored by maximilianocuria).
Add the _lineSpacing value set by the user.
Jan 29 2017, 2:18 PM

Jan 27 2017

maximilianocuria committed R319:a779c8314a7d: Pre process the -e custom command argument (authored by maximilianocuria).
Pre process the -e custom command argument
Jan 27 2017, 2:52 PM

Dec 6 2016

maximilianocuria added reviewers for D3610: Delete the properties window if closed: KDE PIM, knauss.

This commit fixed the Debian bug reported in: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=845553

Dec 6 2016, 7:37 PM · KDE PIM
maximilianocuria retitled D3610: Delete the properties window if closed from to Delete the properties window if closed.
Dec 6 2016, 7:33 PM · KDE PIM