- User Since
- Dec 6 2016, 7:26 PM (148 w, 5 d)
May 22 2018
May 17 2018
May 16 2018
May 15 2018
May 14 2018
Sadly the commit went without the GIT_SILENT, sorry about that. I did:
git commit -amend # to add the GIT_SILENT
I guess that the arc land called another arc amend.
Please let me know if it's okay to land this kind of changes directly.
May 11 2018
May 9 2018
May 8 2018
Btw, Debian users confirmed that this fixes the issue: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=897687
I'm not sure, but I think that pam could be called from a process that has the stdin/stdout/stderr redirected to pipes, so disconnecting those for a long lived process would avoid a possible broken pipe. Now, if that's so, why it's not clossing stdin and stdout, I don't know.
May 5 2018
Update comments as suggested.
I can reproduce the issue in openbox and cinnamon. I think this is related to qt5ct which always tries to print things to stderr. I guess having the debug messages enabled would also trigger the issue.
May 4 2018
A somewhat simpler version, just delay the close(2) call. Based on @davidedmundson
May 2 2018
Apr 25 2018
Mmh, the accept revision doesn't work as a +1, does it?
I was intending to say +1/thumbs up, but I would still prefer somebody else to review this. After all, I sent forwarded the original patch, clearly I want this to land, but it's up the frameworks/ktexteditor developers/maintainers to decide.
Why dropping syncToDisk? Why is that related to the current issue?
Apr 19 2018
You are planning a bit ahead, aren't you. :)
Apr 23 2017
Jan 29 2017
Jan 27 2017
Dec 6 2016
This commit fixed the Debian bug reported in: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=845553