Pass socket path as std::string to SocketAddress, FdSender and FdReceiver.
This way FdSender and SocketAddress remain qt-free and FdReceiver doesn't
stand out.
Depends on D12744
dfaure | |
ossi |
Pass socket path as std::string to SocketAddress, FdSender and FdReceiver.
This way FdSender and SocketAddress remain qt-free and FdReceiver doesn't
stand out.
Depends on D12744
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
why aren't you standardizing on std::string? that's cleaner than raw char pointers.
i know we discussed this before to some degree, but i don't remember the particulars.
It was pointed out that using std::string made the API stand out a bit (which btw is true). That's why I used char pointers here.
but so does using raw pointers. as the stl is available here anyway, it seems like the preferable abstraction layer.
edit: the point of the old discussion was that having a non-qt api stands out, which is consistent with what i wrote above. basing the api on stl would be perfectly reasonable given the requirement of having to make it qt-free.