Create socket file in user's runtime directory
ClosedPublic

Authored by chinmoyr on Feb 9 2018, 5:33 PM.

Details

Summary

"/tmp" is world writable so creating socket there is a bad idea. Instead create socket in user's
runtime directory or any directory with permissions 0700. This path will be provided by file
ioslave.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
chinmoyr created this revision.Feb 9 2018, 5:33 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 9 2018, 5:33 PM
chinmoyr requested review of this revision.Feb 9 2018, 5:33 PM
dfaure added a subscriber: dfaure.Mar 4 2018, 10:16 AM

That doesn't look like an atomic commit. In this commit, "path" changes from relative to absolute, but the caller hasn't been updated to actually send an absolute path?

chinmoyr updated this revision to Diff 32414.Apr 17 2018, 5:56 PM
chinmoyr edited the summary of this revision. (Show Details)

Rebased on D10409

ossi accepted this revision.May 6 2018, 9:14 AM
This revision is now accepted and ready to land.May 6 2018, 9:14 AM
chinmoyr abandoned this revision.May 7 2018, 4:17 PM
This comment was removed by chinmoyr.
chinmoyr reclaimed this revision.May 7 2018, 4:19 PM

Sorry, abandoned it by mistake.

This revision is now accepted and ready to land.May 7 2018, 4:19 PM
ossi accepted this revision.May 27 2018, 10:00 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald TranscriptMay 27 2018, 10:00 AM
This revision was automatically updated to reflect the committed changes.