fix some issues reported by clazy
Details
Details
- Reviewers
bruns - Group Reviewers
Baloo Frameworks - Commits
- R293:f887468b172a: fix some issues reported by clazy
tests are OK
Diff Detail
Diff Detail
- Repository
- R293 Baloo
- Branch
- arcpatch-D12578
- Lint
No Linters Available - Unit
No Unit Test Coverage
CMakeLists.txt | ||
---|---|---|
4 ↗ | (On Diff #33247) | I don't think this belongs in here |
src/engine/transaction.cpp | ||
326 ↗ | (On Diff #33247) | Move this one up, before the query.op() == EngineQuery::Phrase) |
508 ↗ | (On Diff #33247) | This is a functional change and should not be hidden between "cosmetical" changes |
src/lib/searchstore.cpp | ||
167 ↗ | (On Diff #33247) | No const here? |
Comment Actions
@mgallien - I think this is trivial to fix up - can you do, so we have one less request open?
Comment Actions
I will do but as I had started working on that as a low priority task, I have not yet been able to correctly fix the issues.
src/lib/searchstore.cpp | ||
---|---|---|
163 | const QList<Term> subterms = ... |
Comment Actions
No, worries, just wanted to make shure this does not stall 1 meter to the finish line ...