fix some issues reported by clazy
ClosedPublic

Authored by mgallien on Apr 28 2018, 1:36 PM.

Details

Summary

fix some issues reported by clazy

Test Plan

tests are OK

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mgallien created this revision.Apr 28 2018, 1:36 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 28 2018, 1:36 PM
mgallien requested review of this revision.Apr 28 2018, 1:36 PM
bruns added a subscriber: bruns.Apr 28 2018, 4:07 PM
bruns added inline comments.
CMakeLists.txt
4 ↗(On Diff #33247)

I don't think this belongs in here

src/engine/transaction.cpp
326–327

Move this one up, before the query.op() == EngineQuery::Phrase)

508

This is a functional change and should not be hidden between "cosmetical" changes

src/lib/searchstore.cpp
167

No const here?

bruns requested changes to this revision.May 3 2018, 6:36 PM
This revision now requires changes to proceed.May 3 2018, 6:36 PM
bruns added a comment.May 15 2018, 2:13 PM

@mgallien - I think this is trivial to fix up - can you do, so we have one less request open?

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald TranscriptMay 15 2018, 2:13 PM

@mgallien - I think this is trivial to fix up - can you do, so we have one less request open?

I will do but as I had started working on that as a low priority task, I have not yet been able to correctly fix the issues.

mgallien updated this revision to Diff 34223.May 15 2018, 7:31 PM

fix some issues

bruns added inline comments.May 15 2018, 7:54 PM
src/lib/searchstore.cpp
163

const QList<Term> subterms = ...

bruns requested changes to this revision.May 17 2018, 6:34 PM

One change pending, then you are good to go ...

This revision now requires changes to proceed.May 17 2018, 6:34 PM
mgallien updated this revision to Diff 34389.May 17 2018, 6:55 PM
  • fix one more issue
mgallien marked an inline comment as done.May 17 2018, 6:56 PM

@bruns Thanks for the review and sorry for my slowness.

bruns accepted this revision.May 17 2018, 7:03 PM

No, worries, just wanted to make shure this does not stall 1 meter to the finish line ...

This revision is now accepted and ready to land.May 17 2018, 7:03 PM
This revision was automatically updated to reflect the committed changes.