fix some issues reported by clazy
ClosedPublic
Actions

Authored by mgallien on Apr 28 2018, 1:36 PM.

Details

Reviewers

Group Reviewers

Baloo
Frameworks

Commits

R293:f887468b172a: fix some issues reported by clazy

Summary

fix some issues reported by clazy

Test Plan

tests are OK

Repository

R293 Baloo

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

mgallien requested review of this revision.Apr 28 2018, 1:36 PM

bruns added inline comments.

CMakeLists.txt
4	I don't think this belongs in here
src/engine/transaction.cpp
326	Move this one up, before the `query.op() == EngineQuery::Phrase)`
508	This is a functional change and should not be hidden between "cosmetical" changes
src/lib/searchstore.cpp
167	No const here?

bruns requested changes to this revision.May 3 2018, 6:36 PM

This revision now requires changes to proceed.May 3 2018, 6:36 PM

@mgallien - I think this is trivial to fix up - can you do, so we have one less request open?

In D12578#262831, @bruns wrote:

@mgallien - I think this is trivial to fix up - can you do, so we have one less request open?

I will do but as I had started working on that as a low priority task, I have not yet been able to correctly fix the issues.

fix some issues

src/lib/searchstore.cpp
163	`const QList<Term> subterms = ...`

One change pending, then you are good to go ...

This revision now requires changes to proceed.May 17 2018, 6:34 PM

@bruns Thanks for the review and sorry for my slowness.

No, worries, just wanted to make shure this does not stall 1 meter to the finish line ...

This revision is now accepted and ready to land.May 17 2018, 7:03 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			CMakeLists.txt (4 lines)
M			autotests/unit/file/pendingfilequeuetest.cpp (8 lines)
M			src/engine/transaction.cpp (18 lines)
M			src/file/fileindexerconfig.cpp (3 lines)
M			src/file/fileindexscheduler.cpp (2 lines)
M			src/file/firstrunindexer.cpp (2 lines)
M			src/file/indexcleaner.cpp (3 lines)
M			src/file/modifiedfileindexer.cpp (2 lines)
M			src/file/newfileindexer.cpp (2 lines)
M			src/file/xattrindexer.cpp (2 lines)
M			src/kioslaves/kded/baloosearchmodule.cpp (2 lines)
M			src/lib/query.cpp (2 lines)
M			src/lib/searchstore.cpp (2 lines)
M			src/lib/taglistjob.cpp (2 lines)
M			src/lib/term.cpp (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	33247	ef0e268		Apr 28 2018, 1:36 PM	★	★
Diff 2	34223	5929332	fix some issues	May 15 2018, 7:31 PM	★	★
Diff 3	34389	5929332	- fix one more issue	May 17 2018, 6:55 PM	★	★
Diff 4	34390	7529727	R293:f887468b172a23e3ee406123f3a3145a5e638f9b	May 17 2018, 7:24 PM	★	★