ScrollViewKCM component to be used when a kcm has a main component which is a generic scrollview
margins are now in charge of the kcm's qml intead of the outer widget
Details
Details
- Reviewers
hein - Group Reviewers
Plasma - Commits
- R296:c175bbfc8861: ScrollViewKCM
made it work with the language kcm
Diff Detail
Diff Detail
- Repository
- R296 KDeclarative
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Does the magic pixel size number for the padding get scaled correctly on hidpi?
And where does System Settings have the magic pixel number from - is it hardcoded there as well or is it a QStyle thing that could change with the style engine?
Could System Settings inject the magic number as a context prop?
Comment Actions
on the current way we have to scale in the kcm yes, it will be scaled
And where does System Settings have the magic pixel number from - is it hardcoded there as well or is it a QStyle thing that could change with the style engine?
yeah, qstyle pixelmetric i fear...
Could System Settings inject the magic number as a context prop?
not really systemsettings doesn't have any access to the kcm engine
Comment Actions
It looks good otherwise and I really want to accept this so I can progress on the Language KCM, but this magic value thing gives me a headache. It's going to break with other QStyles with a different value. We need some sort of fix for that ...