QML applets need to manage padding by themselves
ClosedPublic

Authored by mart on Apr 25 2018, 12:42 PM.

Details

Summary

remove our padding from qml kcms
this fixes the cutted away shadow for InlineMessage

Test Plan

InlineMessages work better now

Diff Detail

Repository
R124 System Settings
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Apr 25 2018, 12:42 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 25 2018, 12:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Apr 25 2018, 12:42 PM
mart updated this revision to Diff 33110.Apr 25 2018, 10:21 PM
  • use pixelmetrics from the style for the padding
abetts added a subscriber: abetts.Apr 25 2018, 10:23 PM

What does this look like now?

hein accepted this revision.Apr 26 2018, 10:39 AM
hein added a subscriber: hein.

Same as before, we're just refactoring to clean some code :)

This revision is now accepted and ready to land.Apr 26 2018, 10:39 AM
This revision was automatically updated to reflect the committed changes.