Fully remove "Application Name" from details panel
AbandonedPublic

Authored by sharvey on Apr 24 2018, 3:46 PM.

Details

Summary

Remove Application Name from details panel; backend code removed long ago

Addresses concerns in R121:b340539eca13

Diff Detail

Repository
R121 Policykit (Polkit) KDE Agent
Branch
remove-appname (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
sharvey created this revision.Apr 24 2018, 3:46 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 24 2018, 3:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sharvey requested review of this revision.Apr 24 2018, 3:46 PM
sharvey updated this revision to Diff 32991.Apr 24 2018, 3:49 PM
  • Corrected Not Applicable to Not Available
sharvey edited the summary of this revision. (Show Details)Apr 24 2018, 3:50 PM

For a removal patch, I see a suspicious amount of green here...

For a removal patch, I see a suspicious amount of green here...

Forgot to pull a fresh master after you committed my previous change. Abandoning and reworking. Argh.

sharvey abandoned this revision.Apr 24 2018, 3:58 PM

No need to abandon this revision; you could pull down master, re-branch, do your changes there, and then issue arc diff --update D12497, and it will replace the diff here with what you have locally.

No need to abandon this revision; you could pull down master, re-branch, do your changes there, and then issue arc diff --update D12497, and it will replace the diff here with what you have locally.

Added to my "Phab/arc" notes for the future.