Fix inconsistent preview spacing and icon wiggly-ness when toggling previews in Icon mode
ClosedPublic

Authored by ngraham on Apr 19 2018, 7:53 PM.

Details

Summary

Dolphin had some code to change the grid spacing when previews were toggled, in an attempt to optimize the view for 3:2 landscape photos. This was problematic for many reasons:

  • Conceptually, it was a bad idea to optimize the view for one specific use case. Previews are useful for more than just landscape photos, and this optimization would be inapplicable to any other set of files.
  • Folders entirely full of images commonly have some portrait-orientation images included too, so even if the goal were appropriate, it was a bad idea to optimize for only having landscape images.
  • For small sizes and medium icons (< 96px), the preview grid size was virtually identical to the non-preview grid size, so it had essentially no effect, and only made the icons wiggle strangely when previews were toggled.
  • For large large sizes (>= 96px), all it did was unnecessarily increase the horizontal grid spacing, actually reducing usability for browsing through folders of images.

Therefore, let's just remove this code.

BUG: 393306
FIXED-IN: 18.04.1

Test Plan
  • Go to SettingsView ModesIcons and make the icon size and preview size identical for 64px
  • Toggle previews on and off
  • Change both sizes to 112x
  • Toggle previews on and off

In both cases, the grid spacing does not change and the icons do not wiggle strangely. The only visual change is that previews turn on or off.

Dolphin still works fine for viewing 3:2 landscape photos. 80px icons:

192px icons:

In fact, it's vastly improved for the >=96px use case since the grid spacing is no longer excessively wide

Diff Detail

Repository
R318 Dolphin
Branch
fix-inconsistent-preview-grid-spacing (branched from Applications/18.04)
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham requested review of this revision.Apr 19 2018, 7:53 PM
ngraham created this revision.
ngraham edited the test plan for this revision. (Show Details)Apr 19 2018, 7:55 PM
ngraham edited the summary of this revision. (Show Details)Apr 19 2018, 8:08 PM
hein accepted this revision.Apr 19 2018, 8:46 PM
This revision is now accepted and ready to land.Apr 19 2018, 8:46 PM
ngraham closed this revision.Apr 19 2018, 8:52 PM