Make it possible to disable the build of okularkirigami
ClosedPublic

Authored by apol on Apr 19 2018, 2:38 PM.

Details

Summary

Some distros seem to have the option.

BUG: 393119

Test Plan

Still builds, can disable build

Diff Detail

Repository
R223 Okular
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol created this revision.Apr 19 2018, 2:38 PM
Restricted Application added a project: Okular. · View Herald TranscriptApr 19 2018, 2:38 PM
apol requested review of this revision.Apr 19 2018, 2:38 PM
lbeltrame added inline comments.Apr 19 2018, 2:46 PM
CMakeLists.txt
127–130

Doesn't specify much about what a "convergent" application is (unless it's specified elsewhere). Perhaps "Builds a Kirigami-based, convergent version of Okular"?

apol updated this revision to Diff 32616.Apr 19 2018, 11:00 PM

Improve description

lbeltrame added inline comments.Apr 20 2018, 4:58 AM
mobile/app/package/contents/ui/Documents.qml
56

This, and all the changes in Document.qml are unrelated.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 22 2018, 8:23 PM
This revision was automatically updated to reflect the committed changes.