Differential D12345

Add marginEnd for RTL layouts
ClosedPublic
Actions

Authored by nicolasfella on Apr 19 2018, 11:47 AM.

Details

Reviewers
mtijink
Group Reviewers
KDE Connect
Commits
R225:8a2ea77030ba: Add marginEnd for RTL layouts

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Apr 19 2018, 11:47 AM
Restricted Application added a project: KDE Connect. · View Herald TranscriptApr 19 2018, 11:47 AM
nicolasfella requested review of this revision.Apr 19 2018, 11:47 AM
mtijink added a subscriber: mtijink.Apr 21 2018, 6:05 PM

Shouldn't this replace the layout_marginRight? Now we get margins on both sides?

nicolasfella added a comment.Apr 23 2018, 11:00 AM
In D12345#251154, @mtijink wrote:

Shouldn't this replace the layout_marginRight? Now we get margins on both sides?

When I remove marginRight Android Studio warns about marginEnd not being available on API < 17 and suggests also adding marginRight, so I assume it handles it well when both are set

mtijink accepted this revision.Apr 24 2018, 5:36 PM

Ah okay, makes sense!

This revision is now accepted and ready to land.Apr 24 2018, 5:36 PM
Closed by commit R225:8a2ea77030ba: Add marginEnd for RTL layouts (authored by nicolasfella). · Explain WhyApr 24 2018, 5:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33004

View Options

res/layout-land/activity_mpris.xml

Loading...