kateproject: add submodule listing support for git projects
ClosedPublic

Authored by michalhumpula on May 1 2018, 1:08 PM.

Details

Reviewers
cullmann
Group Reviewers
Kate
Summary

Please consider adding support for listing git submodule files in project file tree.

Diff Detail

Repository
R40 Kate
Lint
Lint Skipped
Unit
Unit Tests Skipped
michalhumpula created this revision.May 1 2018, 1:08 PM
Restricted Application added a project: Kate. · View Herald TranscriptMay 1 2018, 1:08 PM
michalhumpula requested review of this revision.May 1 2018, 1:08 PM
cullmann accepted this revision.May 2 2018, 5:19 AM
cullmann added a subscriber: cullmann.

Why not ;=)

Nitpick:

I would use QFile::exists(modulesPath)

This revision is now accepted and ready to land.May 2 2018, 5:19 AM
dhaumann closed this revision.May 27 2018, 10:34 AM
dhaumann added a subscriber: dhaumann.

@michalhumpula This was committed already with 0a96383144e11a6608cbee6a233ffafc4007704d right? I close this revision, probably the commit hooks did not work as expected or so.

Restricted Application added a subscriber: kwrite-devel. · View Herald TranscriptMay 27 2018, 10:34 AM

@michalhumpula This was committed already with 0a96383144e11a6608cbee6a233ffafc4007704d right? I close this revision, probably the commit hooks did not work as expected or so.

Yes, plase. Don't know how it works on phabricator now.

  1. make a branch: git checkout -b MyNiceFix origin/master
  2. commit in this branch
  3. arc diff # now you have a phabricator review D12345
  4. reviewers review
  5. you change your branch, and again: arc diff, to update the online review
  6. you get your OK: arc land

You are done, the branch is merged to master and pushed, the phabricator D12345 reivew request is closed, and your local git branch is deleted. :-)