Differential D12310

Keyboard control support [T8492]
ClosedPublic
Actions

Authored by harrymecwan on Apr 18 2018, 2:14 PM.

Details

Reviewers
timotheegiet
Group Reviewers
GCompris: Improvements
Maniphest Tasks
T8492: Lights off, implement keyboard control support
Summary

Implemented Keyboard control support.
Disabled keyboard and mouse clicks during bonus.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
harrymecwan created this revision.Apr 18 2018, 2:14 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptApr 18 2018, 2:14 PM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript
harrymecwan requested review of this revision.Apr 18 2018, 2:14 PM
amankumargupta added inline comments.Apr 18 2018, 2:54 PM
src/activities/lightsoff/Lightsoff.qml
58

As everything is done with items.blockClicks only, this can directly be set to false and blockClicks variable in background can be removed.

amankumargupta added a comment.Apr 18 2018, 2:59 PM

The last row windows gets overridden by the bar: https://pasteboard.co/HhcllOA.png

Also can you please remove individual reviewers and add group reviwers?

harrymecwan updated this revision to Diff 32489.Apr 18 2018, 5:20 PM

Removed blockClicks property as suggested.
The Bar does not overlap with last row of windows.

amankumargupta added a subscriber: amankumargupta.Apr 18 2018, 7:14 PM
amankumargupta added inline comments.
src/activities/lightsoff/Lightsoff.qml
204

Can these two BarButton be refactored into one?

timotheegiet accepted this revision.May 9 2018, 11:30 AM
timotheegiet added a subscriber: timotheegiet.

Accepting the patch, I'll look at the button refactoring.

This revision is now accepted and ready to land.May 9 2018, 11:30 AM
timotheegiet closed this revision.May 9 2018, 11:30 AM

Revision Contents
Changeset List

Diff 32489

View Options

src/activities/lightsoff/Lightsoff.qml

Loading...
View Options

src/activities/lightsoff/lightsoff.js

Loading...
View Options

src/core/BarButton.qml

Loading...