Fix duplicate and markup displaying failed-save message box

Authored by muhlenpfordt on Apr 18 2018, 6:36 AM.

Description

Fix duplicate and markup displaying failed-save message box

Summary:
When saving of a file fails, two dialogs are displayed. One of them
contains markup tags like <html> and <tt>.
The duplicate message box is caused by KJob's (not disabled) internal
error handling. The markup is displayed because of using strings with
markup as argument for xi18n* functions without special handling.

BUG: 393170
FIXED-IN: 18.04.1

Test Plan:

  1. Open Gwenview in View or Browse Mode
  2. FileSave As or Ctrl++S
  3. Try to save in a folder you don't have write permission (e.g. Root)
  4. Error message box should display only once and without markup tags
  1. Open Gwenview in View or Browse Mode
  2. Edit a readonly file (e.g. rotate with Ctrl+R)
  3. Click Save or Save All
  4. Error message box should display only once and without markup tags

Reviewers: Gwenview, rkflx

Reviewed By: Gwenview, rkflx

Subscribers: rkflx

Differential Revision: https://phabricator.kde.org/D12302

Details

Committed
muhlenpfordtApr 19 2018, 9:37 AM
Reviewer
Gwenview
Differential Revision
D12302: Fix duplicate and markup displaying failed-save message box
Parents
R260:cd18339fe959: Fix View Mode session restore
Branches
Unknown
Tags
Unknown