When Android sends a list of possible actions add them to the notification. When the action is triggered send a package containing the id and the action back
CCBUG: 366475
Details
Details
- Reviewers
apol - Group Reviewers
KDE Connect - Commits
- R224:957975898bfc: Add actions to notifications
R224:e65743c0c163: Add actions to notifications
Send dummy notification, see the actions, trigger it, look for received package on Android
Diff Detail
Diff Detail
- Repository
- R224 KDE Connect
- Branch
- arcpatch-D12293_1
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 7032 Build 7050: arc lint + arc unit
plugins/notifications/notification.cpp | ||
---|---|---|
114 | Not sure if that can happen but it looks like you might clear m_actions at a point where a notifications still shown and then m_actions[actionIndex] would be out of bounds And also, like the previous comment, when "Reply" is added, the index shifts. | |
132 | You change m_actions after having called setActions() above | |
137 | Whitespace |