BUG: 393190
Add checkbox to (de)select all
Old proposal:
Details
Details
- Reviewers
broulik - Group Reviewers
KDE Connect - Commits
- R225:e4ffd3d3cf02: Enable (de)selecting all apps in notification filter
Deselect all, verify that no notification is coming from test app.
Select all, ...
Deselect all, select single app, ...
Diff Detail
Diff Detail
- Repository
- R225 KDE Connect - Android application
- Branch
- selectall
- Lint
No Linters Available - Unit
No Unit Test Coverage
| src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationFilterActivity.java | ||
|---|---|---|
| 217 | Why in a thread? The previous code didn't do that. | |
| src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationFilterActivity.java | ||
|---|---|---|
| 217 | The database operation is quite expensive. Previously only one item at a time was updated so it was only very short. Now all items are updated at once resulting in a noticeable lag when done in the UI thread | |
Comment Actions
Thanks a lot!
However, is there something "more elegant" like a header with a checkbox, like the ones found in a TreeView where the header checkbox will select and unselect all? (Just asking, I think the buttons are fine)
| src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationFilterActivity.java | ||
|---|---|---|
| 217 | Can't we do something like UPDATE checked = false (like in SQL)? So only one query for all checks at once. | |
Comment Actions
Wouldn't it make more sense to have a button that allows to blacklist applications? It will be hard to see what's going on here.
Comment Actions
I don't think having both a black- and a whilelist would improve things. Maybe VDG has an opinion on it
Comment Actions
Where do you set the initial state of the "all" checkbox? I wanted to suggest that you add the case where some are selected an some are not, and set it to "indeterminate" in that case, but I couldn't find the code for the initial state.