shell: Display generic project managers again
ClosedPublic

Authored by mschwarz on Apr 17 2018, 11:53 AM.

Details

Summary

This fixes a regression in 3a74e103e03a which prevents empty filter lines
in the file dialog, but also removes plugins with empty filters from
the list of project managers.

This commit adds a second list for generic project managers to avoid
storing these in the project filters list.

Test Plan

Launch KDevelop, open the Import / Open Project dialog, select an empty folder, and click next. The Generic Project Manager should be shown in the dropbox.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mschwarz created this revision.Apr 17 2018, 11:53 AM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptApr 17 2018, 11:53 AM
mschwarz requested review of this revision.Apr 17 2018, 11:53 AM
mschwarz added a reviewer: KDevelop.
mwolff accepted this revision.Apr 17 2018, 12:04 PM
mwolff added subscribers: kossebau, mwolff.

lgtm, @kossebau?

This revision is now accepted and ready to land.Apr 17 2018, 12:04 PM

My bad, can see how this broke.

Not tested the patch yet, just executed mentally and LGTM as well, besides the issue mentioned. Will have a closer look tonight.

kdevplatform/shell/openprojectdialog.cpp
104

Isn't this still missing to add the plugininfo to m_projectPlugins?

Adding that would be something that should always be done, and thus be before this if-else.

mschwarz updated this revision to Diff 32385.Apr 17 2018, 1:07 PM

Fixed issue with m_projectPlugins. Sorry, I did not test far enough. Thank you @kossebau for catching that even without testing ;-)

mschwarz marked an inline comment as done.Apr 17 2018, 1:08 PM
kossebau accepted this revision.Apr 18 2018, 11:19 AM
kossebau added subscribers: brauch, kfunk.

Fixes things for me.

Please to 5.2 branch.

@brauch @kfunk This fixes a regression introduced by 3a74e103e03afea5946e96d12540ce32cb2f67bc part of 5.2.2. So IMHO would be good to move the tag and include this patch as well for the release.

This revision was automatically updated to reflect the committed changes.

Fixes things for me.

Please to 5.2 branch.

@brauch @kfunk This fixes a regression introduced by 3a74e103e03afea5946e96d12540ce32cb2f67bc part of 5.2.2. So IMHO would be good to move the tag and include this patch as well for the release.

+1. We'll check once we're ready to do the release, which should be 'ASAP' (as usual).