Differential D12244

new resize policy
ClosedPublic
Actions

Authored by mart on Apr 16 2018, 12:55 PM.

Details

Reviewers
None
Group Reviewers
VDG
Plasma
Commits
R296:ed25dc538941: new resize policy
Summary

the grid view always takes the full kcm
the extra space is added as space between icons columns

BUG: 391910

Test Plan

tested on various sizes

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Apr 16 2018, 12:55 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 16 2018, 12:55 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
mart requested review of this revision.Apr 16 2018, 12:55 PM
mart added a reviewer: Plasma.Apr 16 2018, 12:56 PM
mart edited the test plan for this revision. (Show Details)
mart added a comment.EditedApr 16 2018, 12:58 PM
This comment has been deleted.
ngraham edited the summary of this revision. (Show Details)Apr 16 2018, 12:59 PM
mart added a comment.Apr 16 2018, 1:01 PM

vokoscreen-2018-04-16_14-49-45.mkv564 KBDownload

mart updated this revision to Diff 32280.Apr 16 2018, 1:26 PM
  • binding loops --
mart updated this revision to Diff 32287.Apr 16 2018, 2:39 PM
  • better centering
broulik added a subscriber: broulik.Apr 16 2018, 2:47 PM

Fine in principle but it doesn't enforce any minimum spacing

mart updated this revision to Diff 32291.Apr 16 2018, 2:56 PM
  • ensure items never overlap
This revision was not accepted when it landed; it landed in state Needs Review.Apr 16 2018, 2:57 PM
Closed by commit R296:ed25dc538941: new resize policy (authored by mart). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32292

View Options

src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

Loading...
View Options

src/qmlcontrols/kcmcontrols/qml/GridView.qml

Loading...
View Options

src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml

Loading...