Create a public writeViewConfig() function so the open/save dialog itself can call it
AbandonedPublic
Actions

Authored by ngraham on Apr 15 2018, 11:29 PM.

Details

Reviewers

None

Group Reviewers

Summary

D12227 fixes 209559 for the case when the user presses the Cancel button, but not when the dialog is closed via the Escape key or the titlebar's close button. In order to do that, changes to the QPA plugin are needed. To facilitate it, KFileWidget needs a public interface to the writeViewConfig() function needs so that the dialog can call it. This patch does that.

Test Plan

Compile and deploy KIO, run tests (no regressions), interact with a file open/save dialog; all still work.

Diff Detail

Repository

R241 KIO

Branch

public-writeviewconfig-function

Lint

No Linters Available

Unit

No Unit Test Coverage

ngraham created this revision.Apr 15 2018, 11:29 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptApr 15 2018, 11:29 PM

ngraham requested review of this revision.Apr 15 2018, 11:29 PM

ngraham added a dependent revision: D12240: Save the dialog view settings when closing the dialog without hitting the cancel button.

ngraham mentioned this in D12227: Save the dialog view settings even when canceling.Apr 17 2018, 3:10 AM

ngraham edited the summary of this revision. (Show Details)Apr 17 2018, 3:13 AM

ngraham edited the test plan for this revision. (Show Details)

anthonyfieroni mentioned this in D12240: Save the dialog view settings when closing the dialog without hitting the cancel button.Apr 17 2018, 3:45 AM

Don't need this anymore, since @anthonyfieroni showed me a much better way to accomplish D12240!

ngraham abandoned this revision.Apr 17 2018, 5:01 AM

ngraham removed a dependent revision: D12240: Save the dialog view settings when closing the dialog without hitting the cancel button.

ngraham mentioned this in R241:b49e4dd526f6: Save the dialog view settings even when canceling.Apr 17 2018, 10:34 PM

Revision Contents
Changeset List

			Path	Packages
M			src/filewidgets/kfilewidget.h (7 lines)
M			src/filewidgets/kfilewidget.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	32235	371e523		Apr 15 2018, 11:29 PM	★	★

Create a public writeViewConfig() function so the open/save dialog itself can call itAbandonedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 32235

src/filewidgets/kfilewidget.h

src/filewidgets/kfilewidget.cpp

Create a public writeViewConfig() function so the open/save dialog itself can call it
AbandonedPublic
Actions

Revision Contents
Changeset List