Differential D12234

Update unit tests after removing "this month" and "last month" items
ClosedPublic
Actions

Authored by joselema on Apr 15 2018, 8:48 PM.

Details

Reviewers
davidedmundson
ngraham
Commits
R241:b526f154d0de: Update unit tests after removing "this month" and "last month" items
Summary

Hi,

I think since this change https://phabricator.kde.org/D11767 the kio unit tests are having a regression; if the "This Month" and "Last Month" items are removed, the corresponding unit tests should be removed along with the change.

Test Plan

I have tested this patch adding it to kubuntu's packaging; it fixes the unit tests for us, so it would be nice to get this done in the KDE scope in order to minimize distro patching.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
joselema created this revision.Apr 15 2018, 8:48 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 15 2018, 8:48 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
joselema requested review of this revision.Apr 15 2018, 8:48 PM
ngraham accepted this revision.Apr 15 2018, 11:40 PM

Thanks, this fixes that test failure for me. Sorry for the breakage!

baloonurl *cringes*

This revision is now accepted and ready to land.Apr 15 2018, 11:40 PM
Closed by commit R241:b526f154d0de: Update unit tests after removing "this month" and "last month" items (authored by joselema). · Explain WhyApr 19 2018, 6:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mautotests/kfileplacesviewtest.cpp (16 lines)

Diff 32593

View Options

autotests/kfileplacesviewtest.cpp

Loading...