Differential D12192

Decode more documentUrls
Needs RevisionPublic
Actions

Authored by michaelh on Apr 14 2018, 11:46 AM.

Details

Reviewers

bruns

Group Reviewers

Baloo

Summary

Assume decoding documentUrl with QFile::decodeName has been forgotten.

Test Plan

make test

Diff Detail

Repository

R293 Baloo

Branch

file-encoding (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

michaelh created this revision.Apr 14 2018, 11:46 AM

Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 14 2018, 11:46 AM

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

michaelh requested review of this revision.Apr 14 2018, 11:46 AM

michaelh added inline comments.Apr 14 2018, 11:49 AM

src/engine/transaction.cpp
469	For your convenience

Can you add a little bit more info to the commit message, e.g. an example how the output looks before and after?

This revision now requires changes to proceed.Apr 15 2018, 2:13 AM

In D12192#246449, @bruns wrote:

Can you add a little bit more info to the commit message, e.g. an example how the output looks before and after?

Examples? I don't know...
I realized the necessity to QFile::decodeName() while working on baloodb. It could not find a file "I´m Haunted.txt" without it. The rest was find and replace over the code in src/**. In most cases QFile::decodeName() was used, so I thought it was just forgotten here. src/file/indexcleaner.cpp is dead code, btw.
Feel free to edit the description if you have a better wording in mind.

Revision Contents
Changeset List

			Path	Packages
M			src/engine/transaction.cpp (2 lines)
M			src/file/indexcleaner.cpp (2 lines)
M			src/file/unindexedfileindexer.cpp (2 lines)
M			src/lib/searchstore.cpp (4 lines)