$ arc patch D12165
 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D12165.
Created and checked out branch arcpatch-D11285. <====== ???
Prüfe Patch src/engine/transaction.h ...
...
 Cherry Pick Failed!
 Exception 
Command failed with error #1!
COMMAND
git cherry-pick 'arcpatch-D11285'<====== ???

michaelh added a task: T8250: Sanitize the database.Apr 13 2018, 9:06 AM

LGTM and works as expected.
To make it run I had to manually edit the Raw diff and patch.
https://phabricator.kde.org/R293:07601590347f25ec1ec805e7df16e1f2d6badc9c was pulled at around 9:30 CET, but not last night, maybe not even at Fri, Apr 13, 05:10.
Please rebase. And do you have an explanation for this delay?

michaelh mentioned this in T8506: Arcanist doesn't apply patches correctly in certain circumstances..Apr 13 2018, 10:09 AM

rebase

michaelh accepted this revision.Apr 13 2018, 8:51 PM

This revision is now accepted and ready to land.Apr 13 2018, 8:51 PM

Closed by commit R293:0491ba6e8e96: Use QStorageInfo instead of a homegrown implementation (authored by bruns). · Explain WhyApr 13 2018, 11:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/engine/experimental/databasesanitizer.cpp (88 lines)
M			src/engine/fsutils.h (11 lines)
M			src/engine/fsutils.cpp (27 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	32033	5a0ff54		Apr 13 2018, 3:10 AM	★	★
Diff 2	32078	0760159		Apr 13 2018, 8:39 PM	★	★
Diff 3	32087	0760159	R293:0491ba6e8e96be4d05666dfb40660ad8e85cc83e	Apr 13 2018, 11:17 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
b34413d3b136	ec9ba5d51778	07601590347f	Stefan Brüns	Use QStorageInfo instead of a homegrown implementation (Show More…)	Apr 13 2018, 6:33 PM

Status	Author	Revision
Accepted	michaelh	D12044 baloodb: Improve interface
Needs Review	michaelh	D12222 baloodb: Use complete access filtering for all outputs
Closed	michaelh	D11753 baloodb: Add clean command
Closed	michaelh	D11745 databasesanitizer: Use flags for filtering
Closed	bruns	D12165 Use QStorageInfo instead of a homegrown implementation
Closed	michaelh	D11452 sanitizer: Improve device listing
Closed	michaelh	D11287 Introduce baloodb CLI tool
Closed	michaelh	D11285 Introduce sanitizer class

Diff 32078

View Options

src/engine/experimental/databasesanitizer.cpp

View Options

src/engine/fsutils.h

View Options

Use QStorageInfo instead of a homegrown implementationClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 32078

src/engine/experimental/databasesanitizer.cpp

src/engine/fsutils.h

src/engine/fsutils.cpp

Use QStorageInfo instead of a homegrown implementation
ClosedPublic
Actions

Revision Contents
Changeset List