| teran | |
| cfeck |
| KDE Applications |
This patch allows to press the equal sign again in order to repeat the last action again. For example "5+10" yields "15" on enter
and if you press enter or equal sign again it repeats the "+ 10" by showing you "25" now.
This behaivior is disabled by default and can be turned on in KCalc's settings panel under "Misc".
FEATURE: 108473
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I like the idea. I remember calculators that enabled "repeated operations" automatically when the operation key was pressed twice (and cleared the mode when pressed again). A 'K' was displayed (whatever that meant) next to the memory indicator, whenever the repeated mode was activated.
What I am unsure about is the label of the checkbox. It could mention "Operation" instead of "Action", and the wording "Equal Press" sounds confusing due to word classes. My suggestion for the label would be something like "Repeat Operation for each Result". Maybe :)
The setting is not saved, is it? I guess users would expect any setting from the settings dialog to not be temporary, unlike maybe options that are toggled via the menus.
| kcalc_core.cpp | ||
|---|---|---|
| 846 | Space before '{' | |
I've seen similiar things to the "K" indicator marker, might be useful to know whether you already pressed equal or not, so you don't mess up your result.
The settings should be saved on pressing Apply or Ok. I'm using the same KConfig (kcalc.kcfg) technique like the other settings and it seems persistent to me.
Like your suggestion of the label, will change that.
| general.ui | ||
|---|---|---|
| 199 | Casing is still wrong. | |