Differential D12025

Terminate query execution early if subterm returns empty result set
ClosedPublic
Actions

Authored by bruns on Apr 7 2018, 6:15 PM.

Details

Reviewers
michaelh
dhaumann
Group Reviewers
Baloo
Frameworks
Commits
R293:5bf021ee134d: Terminate query execution early if subterm returns empty result set
Summary

Leaf queries may return an empty result set, which is signalled by
returning a nullptr. Immediately break if the query is part of an
Term::And, and omit it if it is a Term::Or.
As creating the PostingOperator implicitly executes the database
query, it is beneficial to omit queries whose result is not used
anyway.

Diff Detail

Repository
R293 Baloo
Branch
terminate_empty_terms_early
Lint
No Linters Available
Unit
No Unit Test Coverage
bruns created this revision.Apr 7 2018, 6:15 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 7 2018, 6:15 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
bruns requested review of this revision.Apr 7 2018, 6:15 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald TranscriptMay 29 2018, 12:21 AM
bruns added a comment.May 29 2018, 12:22 AM

If there a no comments, I will push tomorrow.

dhaumann accepted this revision.May 29 2018, 2:53 AM
This revision is now accepted and ready to land.May 29 2018, 2:53 AM
Closed by commit R293:5bf021ee134d: Terminate query execution early if subterm returns empty result set (authored by bruns). · Explain WhyMay 29 2018, 11:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/engine/transaction.cpp (13 lines)
Msrc/lib/searchstore.cpp (10 lines)

Diff 31612

View Options

src/engine/transaction.cpp

Loading...
View Options

src/lib/searchstore.cpp

Loading...