@ngraham : I've added you as a reviewer, as I've initially stumbled (again) over KLook due to Bug 272539, and you were the last one active there. If you know anyone else who this might concern, please add them. This is really mostly meant as a RFC, and to probe if there is even interest in reviving KLook.

You bet there's interest!!! Thanks so much for doing this. The real killer feature is Dolphin integration via the space bar and arrow keys (to switch the focus to other fies). It would be great to get that working again.

Is there a reason to require CMake 3.10? That's pretty new. I was able to build the patched versio just fine with 3.5.1.

Wanna add an .arcconfig file as part of this patch too?

If and when this is returned from death to zombie form, I will take the lead on a visual overhaul/modernization.

Thanks again for this fantastic work!

In D11844#237793, @ngraham wrote:

Is there a reason to require CMake 3.10? That's pretty new. I was able to build the patched versio just fine with 3.5.1.

I hadn't any older version to test it with, so this was just a conservative setting, but I guess it might even work with a version older than 3.5

Wanna add an .arcconfig file as part of this patch too?

If you could tell me what belongs into it, I can do it. I'm not really used to arc yet.

In D11844#237794, @fabiank wrote:

In D11844#237793, @ngraham wrote:

Is there a reason to require CMake 3.10? That's pretty new. I was able to build the patched versio just fine with 3.5.1.

I hadn't any older version to test it with, so this was just a conservative setting, but I guess it might even work with a version older than 3.5

Wanna add an .arcconfig file as part of this patch too?

If you could tell me what belongs into it, I can do it. I'm not really used to arc yet.

Just copy the the file from any other repo:

$ cat kio/.arcconfig 
{
  "phabricator.uri" : "https://phabricator.kde.org/"
}

@ngraham : So the dolphin integration works partially (as described above in the summary). I guess some input from the dolphin team would be helpful now. D11875 contains the dolphin patch so that it can be easier reviewed. I'm not so sure whether and how the discussion should be split between the two review requests.

@bcooksley Would it be possible to set up a project page for KLook? Having all the todos as actionable tasks in a Workboard and being able to prioritize them would be more helpful than having half of them as a list in a text document, and the other half merely existing in my head. Also, when @ngraham decides to list all the usability and design improvements that are needed (which isn't really my area of expertise), he could put them there, too.

• TODO: new mimetype detection breaks the directory case, as it is considered an error (though we still get inode/directory as the result). Add special detection for dirs.

Magnificent.