Differential D11782

Introduce OutputScreens class
ClosedPublic
Actions

Authored by romangg on Mar 29 2018, 2:44 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:3482378278d6: Introduce OutputScreens class
Summary

Lift high-level properties into new Screens child class for platform plugins
using the Output class.

Directly make DrmScreens a child class of OutputScreens.

Test Plan

Manually and auto tests with 94%.

Diff Detail

Branch
screensRework
Lint
No Linters Available
Unit
No Unit Test Coverage
romangg requested review of this revision.Mar 29 2018, 2:44 PM
romangg created this revision.
romangg updated this revision to Diff 30879.Mar 29 2018, 8:36 PM

Rebase on parent revision changes

zzag added a subscriber: zzag.Mar 29 2018, 8:50 PM
zzag added inline comments.
outputscreens.cpp
45

enOuts can be const. The same applies to enOuts in geometry (), name(), size(), scale(), and physicalSize(), I guess.

romangg added inline comments.Mar 29 2018, 8:55 PM
outputscreens.cpp
45

Right, I will address these when pushing. Thanks!

romangg updated this revision to Diff 32284.Apr 16 2018, 1:32 PM
  • Rebase
  • Add missing const qualifiers
romangg marked 2 inline comments as done.Apr 16 2018, 1:32 PM
romangg updated this revision to Diff 33435.May 1 2018, 7:58 PM

Rebase on parent revision changes

romangg updated this revision to Diff 35362.Jun 1 2018, 6:34 PM

Rebase on parent revision changes

romangg updated this revision to Diff 35692.Jun 6 2018, 4:56 PM

Rebase on parent revision changes

romangg updated this revision to Diff 35693.Jun 6 2018, 5:03 PM

Small cleanup

davidedmundson accepted this revision.Jul 30 2018, 1:41 PM
This revision is now accepted and ready to land.Jul 30 2018, 1:41 PM
Closed by commit R108:3482378278d6: Introduce OutputScreens class (authored by romangg). · Explain WhyAug 31 2018, 10:34 AM
This revision was automatically updated to reflect the committed changes.
Restricted Application added a project: KWin. · View Herald TranscriptAug 31 2018, 10:34 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (1 line)
Poutputscreens.h (39 lines)
Copied from plugins/platforms/drm/screens_drm.h
AMoutputscreens.cpp (132 lines)
Mplugins/platforms/drm/egl_gbm_backend.cpp (1 line)
Mplugins/platforms/drm/scene_qpainter_drm_backend.cpp (1 line)
Pplugins/platforms/drm/screens_drm.h (17 lines)
Copied to outputscreens.h
Mplugins/platforms/drm/screens_drm.cpp (114 lines)

Diff 35692

View Options

CMakeLists.txt

Loading...
View Options

outputscreens.h

Loading...
View Options

outputscreens.cpp

Loading...
View Options

plugins/platforms/drm/egl_gbm_backend.cpp

Loading...
View Options

plugins/platforms/drm/scene_qpainter_drm_backend.cpp

Loading...
View Options

plugins/platforms/drm/screens_drm.h

Loading...
View Options

plugins/platforms/drm/screens_drm.cpp

Loading...