Differential D11782

Introduce OutputScreens class
ClosedPublic
Actions

Authored by romangg on Mar 29 2018, 2:44 PM.

Tags

Subscribers

Details

Reviewers

Group Reviewers

Commits

R108:3482378278d6: Introduce OutputScreens class

Summary

Lift high-level properties into new Screens child class for platform plugins
using the Output class.

Directly make DrmScreens a child class of OutputScreens.

Test Plan

Manually and auto tests with 94%.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

romangg requested review of this revision.Mar 29 2018, 2:44 PM

romangg created this revision.

romangg added a dependency: D11781: Introduce generic Output class.Mar 29 2018, 2:44 PM

romangg added a dependent revision: D11789: [platforms/virtual] Let VirtualOutput inherit Output.Mar 29 2018, 8:01 PM

Rebase on parent revision changes

zzag added a subscriber: zzag.Mar 29 2018, 8:50 PM

zzag added inline comments.

outputscreens.cpp
45	enOuts can be const. The same applies to enOuts in geometry (), name(), size(), scale(), and physicalSize(), I guess.

romangg added inline comments.Mar 29 2018, 8:55 PM

outputscreens.cpp
45	Right, I will address these when pushing. Thanks!

Rebase
Add missing const qualifiers

romangg marked 2 inline comments as done.Apr 16 2018, 1:32 PM

Rebase on parent revision changes

romangg mentioned this in D11781: Introduce generic Output class.May 4 2018, 12:25 PM

Rebase on parent revision changes

Rebase on parent revision changes

Small cleanup

davidedmundson accepted this revision.Jul 30 2018, 1:41 PM

This revision is now accepted and ready to land.Jul 30 2018, 1:41 PM

Closed by commit R108:3482378278d6: Introduce OutputScreens class (authored by romangg). · Explain WhyAug 31 2018, 10:34 AM

This revision was automatically updated to reflect the committed changes.

Restricted Application added a project: KWin. · View Herald TranscriptAug 31 2018, 10:34 AM

Restricted Application added a subscriber: kwin. · View Herald Transcript

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (1 line)
P			outputscreens.h (39 lines) Copied from plugins/platforms/drm/screens_drm.h
A	M		outputscreens.cpp (132 lines)
P			plugins/platforms/drm/screens_drm.h (17 lines) Copied to outputscreens.h
M			plugins/platforms/drm/screens_drm.cpp (112 lines)

Diff 40748

CMakeLists.txt

Loading...

outputscreens.h

Loading...

outputscreens.cpp

Loading...

plugins/platforms/drm/screens_drm.h

Loading...

plugins/platforms/drm/screens_drm.cpp

Loading...