Differential D11761

clip on the rectangle containing the GridView instead of the view itself
ClosedPublic
Actions

Authored by mgallien on Mar 27 2018, 8:54 PM.

Details

Reviewers
januz
astippich
Group Reviewers
Elisa
Maniphest Tasks
T8345: Fix shadows of first line elements i grid views
Commits
R255:c08adbcc81f6: clip on the rectangle containing the GridView instead of the view itself
R255:29240b42bddc: clip on the rectangle containing the GridView instead of the view itself
Summary

clip on the rectangle containing the GridView instead of the view itself

this avoid cutting the shadow of the fist line before any scroll on the view

Test Plan

shadow now looks fine

Diff Detail

Repository
R255 Elisa
Branch
fixViewMargins
Lint
No Linters Available
Unit
No Unit Test Coverage
mgallien requested review of this revision.Mar 27 2018, 8:54 PM
mgallien created this revision.
mgallien added a comment.Mar 27 2018, 8:56 PM

before

after

astippich accepted this revision.Mar 28 2018, 5:35 PM
This revision is now accepted and ready to land.Mar 28 2018, 5:35 PM
Closed by commit R255:c08adbcc81f6: clip on the rectangle containing the GridView instead of the view itself (authored by mgallien). · Explain WhyMar 28 2018, 8:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/qml/GridBrowserView.qml (3 lines)

Diff 30761

View Options

src/qml/GridBrowserView.qml

Loading...